This repository was archived by the owner on Dec 12, 2022. It is now read-only.
Update webextension-polyfill to work in the most recent Chrome version#78
Open
rafaelsc wants to merge 6 commits intothreejs:masterfrom
Open
Update webextension-polyfill to work in the most recent Chrome version#78rafaelsc wants to merge 6 commits intothreejs:masterfrom
rafaelsc wants to merge 6 commits intothreejs:masterfrom
Conversation
Member
|
Do we even need this polyfill? 🤔 |
Author
|
@mrdoob I don't know. I don't have too much experience with extensions. I tried to remove and look like the change would be bigger. And I only manage to make work upgrading the polyfill, changing the event to be |
|
This changes work fine. Thanks @rafaelsc. Please merge this to master. |
Author
|
Sorry @zadinvit. I don't have permission to complete this PR (merging to master) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
webextension-polyfillto work in the most recent Chrome version.onDOMContentLoadedto load the Tool ScriptThe old
webextension-polyfillis causing issies with Chrome, making you need to refresh many times the page to the extentions start watching the scene.